Improve add reliability: recovery, cancel, and downloads - #7
Merged
Merged
Conversation
…er-installed fonts for CI runs
Make package outcomes drive non-zero exits, isolate staging, roll back partial installs with safe force replace, and classify downloads with cancellable external tools and consistent checksums.
Make package rollback registration-aware, use unique install artifacts, join progress workers on every exit, bound external-process teardown, time-limit error-body drains, and keep rate-limits from advancing candidates.
staticcheck U1000 failed CI on logInstallResultDetails, updateInstallStatus, and installFontsInDebugMode.
… error handling - Removed unused dependency on github.com/blang/semver and updated to use golang.org/x/mod v0.41.0. - Refactored font installation tests to utilize a new control structure for injecting failure scenarios, enhancing test reliability and clarity. - Simplified table rendering in various commands by using default column configurations. - Removed deprecated functions and cleaned up code for better maintainability.
…ment without overcomplicated backup first
…d correct link paths
…ion handling and track incomplete operations
…V1 to V2 on fontget-sources
…check and family classification.
…tion for tracked files and better cancellation handling. Also Fixed error reporting during removal operations.
Without the deleted cross-platform tests, ubuntu staticcheck flags the helpers as unused (U1000).
…ogress messaging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fontget addper the reliability spec: correct failure exits, noninteractive progress, isolated staging, package rollback with safe--force, smarter download fallback, cancellable external tools, and consistent checksums.702f3b1: registration-aware rollback, unique install artifacts + collision checks, progress-worker join on cancel, bounded process/pipe teardown, timed error-body drain, rate-limit no longer advances candidates, structured HTTP status from wget/PowerShell.Test plan
9193badfontget add <id> --force(multi-file package) and cancel during download/install